Catch UnicodeDecodeError in lobster-json
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedarnn
reviewed
Oct 18, 2024
| data = get_item(root = data, | ||
| path = options.test_list, | ||
| required = True) | ||
| except UnicodeDecodeError as decode_error: | ||
| print("%s: File is not encoded in utf-8: %s" % (file_name, decode_error)) |
There was a problem hiding this comment.
I observed that the old string formatting method is used rather than f-strings, is there any specific reason due to which it is preferred?
There was a problem hiding this comment.
No, there is no particular reason. I just used it because it is used everywhere else, to stay consistent.
There was a problem hiding this comment.
This is something we should address in the coding guideline #88
christophkloeffel
previously approved these changes
Oct 21, 2024
The `UnicodeDecodeError` is catched, and an error message is printed. Afterwards `lobster-json` exits. Issue: #102
christophkloeffel
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UnicodeDecodeErroris catched, and an error message is printed.Afterwards
lobster-jsonexits.Issue: #102